Open
Conversation
added 2 commits
July 5, 2019 14:54
Author
|
I've just realized that this project has tests and I just broke them. Please ignore the PR until I fix that :) |
Author
|
Okay, fixed the tests. Found a bug in my code, fixed that too. |
hughdbrown
reviewed
Nov 29, 2019
|
|
||
| return items[start:end] | ||
| start, size = get_group_size_and_start(len(items), total_groups, group_id) | ||
| return items[start:start+size] |
There was a problem hiding this comment.
You could replace all of this with:
return items[group_id:len(items):group_size]
This is the three-argument slice-operator: [start:end:step].
|
@wchill how to reach you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have, say, 25 tests and 8 groups, the current work distribution formula will determine the group size at 4 and then the first 6 groups will be assigned 4 tests each, the 7th will get 1 and the 8th will get 0. This is bad first because it's not as uniform as it could be and second because group 8 will throw an exception (at line 21).
I replaced the formula to fix these issues. Now, all groups get to run at least
items // groupstests, and the firstitems % groupsgroups will receive an extra one. Therefore, the difference between the number of items assigned to any two group will be at most 1. Also, groups with 0 assigned items no longer raise an exception.